[libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, gains and temperature in debug message

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Sep 8 03:41:56 CEST 2022


Extend the debug message in Awb::process() to log the means and color
temperature in addition to the gains. This is useful for debugging the
algorithm behaviour. While at it, set the showpoint flag to print a
fixed number of digits after the decimal point, making logs more
readable.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp
index 2ff67ed98221..ed91e9277a16 100644
--- a/src/ipa/rkisp1/algorithms/awb.cpp
+++ b/src/ipa/rkisp1/algorithms/awb.cpp
@@ -9,6 +9,7 @@
 
 #include <algorithm>
 #include <cmath>
+#include <iomanip>
 
 #include <libcamera/base/log.h>
 
@@ -271,8 +272,12 @@ void Awb::process(IPAContext &context,
 	activeState.awb.gains.automatic.blue = std::clamp(blueGain, 0.0, 1023.0 / 256);
 	activeState.awb.gains.automatic.green = 1.0;
 
-	LOG(RkISP1Awb, Debug) << "Gain found for red: " << activeState.awb.gains.automatic.red
-			      << " and for blue: " << activeState.awb.gains.automatic.blue;
+	LOG(RkISP1Awb, Debug) << std::showpoint
+		<< "Means [" << redMean << ", " << greenMean << ", " << blueMean
+		<< "], gains [" << activeState.awb.gains.automatic.red << ", "
+		<< activeState.awb.gains.automatic.green << ", "
+		<< activeState.awb.gains.automatic.blue << "], temp "
+		<< frameContext.awb.temperatureK << "K";
 }
 
 REGISTER_IPA_ALGORITHM(Awb, "Awb")
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list