[libcamera-devel] [PATCH v2] gstreamer: Check gstreamer version before using newer macros

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Sep 12 16:29:51 CEST 2022


Hi Vedant,

Thank you for the patch.

On Mon, Sep 12, 2022 at 06:35:09PM +0530, Vedant Paranjape via libcamera-devel wrote:
> GST_VIDEO_TRANSFER_BT601 and GST_VIDEO_TRANSFER_BT2020_10 macros are
> defined in GST Version 1.18.0.
> 
> Usage of these macros causes gstlibcamera compilation failure if
> GST_VERSION < 1.18.0. These macros are used only if GST_VERSION >= 1.18.0.
> Fix the following compilation error:
> 
> ../src/gstreamer/gstlibcamera-utils.cpp:157:7: error: ‘GST_VIDEO_TRANSFER_BT601’ was not declared in this scope; did you mean ‘GST_VIDEO_TRANSFER_BT709’?
>   157 |  case GST_VIDEO_TRANSFER_BT601:
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~
>       |       GST_VIDEO_TRANSFER_BT709
> ../src/gstreamer/gstlibcamera-utils.cpp:159:7: error: ‘GST_VIDEO_TRANSFER_BT2020_10’ was not declared in this scope; did you mean ‘GST_VIDEO_TRANSFER_BT2020_12’?
>   159 |  case GST_VIDEO_TRANSFER_BT2020_10:
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       GST_VIDEO_TRANSFER_BT2020_12
> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/gstreamer/gstlibcamera-utils.cpp | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp
> index 4df5dd6c14fd..244a4a79845d 100644
> --- a/src/gstreamer/gstlibcamera-utils.cpp
> +++ b/src/gstreamer/gstlibcamera-utils.cpp
> @@ -154,9 +154,11 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)
>  	case GST_VIDEO_TRANSFER_SRGB:
>  		colorspace->transferFunction = ColorSpace::TransferFunction::Srgb;
>  		break;
> +#if GST_CHECK_VERSION(1, 18, 0)
>  	case GST_VIDEO_TRANSFER_BT601:
> -	case GST_VIDEO_TRANSFER_BT2020_12:
>  	case GST_VIDEO_TRANSFER_BT2020_10:
> +#endif
> +	case GST_VIDEO_TRANSFER_BT2020_12:
>  	case GST_VIDEO_TRANSFER_BT709:
>  		colorspace->transferFunction = ColorSpace::TransferFunction::Rec709;
>  		break;

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list