[libcamera-devel] [PATCH 05/14] libcamera: converter: Add queueBuffer() helper

Jacopo Mondi jacopo at jmondi.org
Wed Sep 14 12:52:07 CEST 2022


We usually don't allow commits without a message, even more in this
case where it would be good explain why the helper is, well, helpful
:)

On Thu, Sep 08, 2022 at 08:48:41PM +0200, Xavier Roumegue via libcamera-devel wrote:
> Signed-off-by: Xavier Roumegue <xavier.roumegue at oss.nxp.com>
> ---
>  include/libcamera/internal/converter.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h
> index e2237c57..ea1deab0 100644
> --- a/include/libcamera/internal/converter.h
> +++ b/include/libcamera/internal/converter.h
> @@ -55,6 +55,12 @@ public:
>  	virtual int queueBuffers(FrameBuffer *input,
>  				 const std::map<unsigned int, FrameBuffer *> &outputs) = 0;
>
> +	int queueBuffer(FrameBuffer *input, FrameBuffer *output)

Does it need documentation ?

> +	{
> +		std::map<unsigned int, FrameBuffer *> _output = { { 0, output } };
> +		return queueBuffers(input, _output);
> +	}
> +
>  	std::string deviceNode_;
>  	Signal<FrameBuffer *> inputBufferReady;
>  	Signal<FrameBuffer *> outputBufferReady;
> --
> 2.37.3
>


More information about the libcamera-devel mailing list