[libcamera-devel] [PATCH] ipa: meson: Fix identation

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Sep 20 00:40:05 CEST 2022


On Mon, Sep 19, 2022 at 11:34:25PM +0100, Kieran Bingham wrote:
> Quoting Laurent Pinchart via libcamera-devel (2022-09-19 18:00:00)
> > meson.build files are indented with 4 spaces, not 2.
> 
> Hrm ... I thought we had a checkstyle rule to catch this ?

We only check that spaces are used for indentation, not tabs. Patches
are welcome :-) It would not be trivial though.

> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  src/ipa/meson.build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/ipa/meson.build b/src/ipa/meson.build
> > index e972bbe896b0..76ad5b445601 100644
> > --- a/src/ipa/meson.build
> > +++ b/src/ipa/meson.build
> > @@ -31,8 +31,8 @@ ipa_modules = get_option('ipas')
> >  # Tests require the vimc IPA, similar to vimc pipline-handler for their
> >  # execution. Include it automatically when tests are enabled.
> >  if get_option('test') and 'vimc' not in ipa_modules
> > -  message('Enabling vimc IPA to support tests')
> > -  ipa_modules += ['vimc']
> > +    message('Enabling vimc IPA to support tests')
> > +    ipa_modules += ['vimc']
> >  endif
> >  
> >  enabled_ipa_modules = []
> > 
> > base-commit: 74ab3f778c848b20cbf8fe299170756ff6ebab1a

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list