[libcamera-devel] [PATCH v4 15/32] ipa: rkisp1: Use base FrameContext class

Jacopo Mondi jacopo at jmondi.org
Wed Sep 21 20:35:22 CEST 2022


Can't argue :)

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

On Thu, Sep 08, 2022 at 04:41:43AM +0300, Laurent Pinchart via libcamera-devel wrote:
> Inherit from the base FrameContext class in the RkISP1 IPAFrameContext.
> As the IPAFrameContext is currently unused, this change is a no-op, but
> it prepares the RkISP1 IPA module for frame context queue support.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/ipa/rkisp1/ipa_context.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h
> index 5590482c6a8c..f6b3e6eb951c 100644
> --- a/src/ipa/rkisp1/ipa_context.h
> +++ b/src/ipa/rkisp1/ipa_context.h
> @@ -14,6 +14,8 @@
>
>  #include <libcamera/geometry.h>
>
> +#include <libipa/fc_queue.h>
> +
>  namespace libcamera {
>
>  namespace ipa::rkisp1 {
> @@ -89,7 +91,7 @@ struct IPAActiveState {
>  	unsigned int frameCount;
>  };
>
> -struct IPAFrameContext {
> +struct IPAFrameContext : public FrameContext {
>  };
>
>  struct IPAContext {
> --
> Regards,
>
> Laurent Pinchart
>


More information about the libcamera-devel mailing list