[libcamera-devel] [PATCH v2 0/6] AEGC controls

[Jacopo Mondi]

Hi Laurent,

On Fri, Aug 19, 2022 at 04:50:13AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Thu, Aug 11, 2022 at 05:02:13PM +0200, Jacopo Mondi via libcamera-devel wrote:
> > Hello
> >   this series collects patch 1/3 from Paul's
> > https://patchwork.libcamera.org/project/libcamera/list/?series=3123
> >
> > with fixups proposed in-reply to that series applied on top.
>
> Thanks for this consolidated version. I'm however a bit worried that
> leaving patches 2/3 and 3/3 from Paul's series out will mean we'll
> forget about them forever. Is there anything that blocks their inclusion
> in this series ?
>

You're right, it would be a shame if those documents get lost.
I have rebased them will send them in reply to this series.

This series is the latest version of the AEGC controls documentation,
I'm not re-sending it as there's a discussion with David here that
might be helpful to provide more context to reviewers.

TL;DR please review this version :)

Thanks
  j


> > The rest of the series ports the existing users in the code base to the
> > new controls.
> >
> > Particularly relevant is the RPi conversion (with Naush and David in Cc)
> > as it's the only pipeline that actually handles the AEGC controls.
> > The RPi changes have been compiled-tested only, hence they certainly
> > require more attention, but that's a start to check if the direction is
> > the desired one.
> >
> > Thanks
> >    j
> >
> > Jacopo Mondi (5):
> >   libcamera: uvcvideo: Register ExposureTimeMode control
> >   test: ipa_data_serialization: Use ExposureTimeMode
> >   ipa: raspberry: Port to the new AEGC controls
> >   ipa: rkisp1: Remove AE-related controls
> >   controls: Remove AeEnable and AeLocked
> >
> > Paul Elder (1):
> >   controls: Introduce AEGC-related controls
> >
> >  .../raspberrypi/controller/agc_algorithm.h    |   6 +
> >  src/ipa/raspberrypi/controller/rpi/agc.cpp    |  24 +-
> >  src/ipa/raspberrypi/controller/rpi/agc.h      |   8 +-
> >  src/ipa/raspberrypi/raspberrypi.cpp           |  76 ++++-
> >  src/ipa/rkisp1/rkisp1.cpp                     |  19 +-
> >  src/libcamera/control_ids.yaml                | 279 ++++++++++++++----
> >  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  54 +++-
> >  .../ipa_data_serializer_test.cpp              |   2 +-
> >  8 files changed, 370 insertions(+), 98 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart