[libcamera-devel] [PATCH v1 4/4] ipa: raspberrypi: Fix the imx296 mono tuning black level

[Naushir Patuck]

Hi Jacopo,

Thank you for the feedback.

On Wed, 28 Sept 2022 at 08:33, Jacopo Mondi <jacopo at jmondi.org> wrote:

> Hi Naush
>
> On Mon, Sep 26, 2022 at 01:29:11PM +0100, Naushir Patuck via
> libcamera-devel wrote:
> > The sensor black level is 60 (in 10-bits), fix this in the mono variant
> tuning
> > file.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > ---
> >  src/ipa/raspberrypi/data/imx296_mono.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/ipa/raspberrypi/data/imx296_mono.json
> b/src/ipa/raspberrypi/data/imx296_mono.json
> > index 490c0fda0cca..b68b11dbd609 100644
> > --- a/src/ipa/raspberrypi/data/imx296_mono.json
> > +++ b/src/ipa/raspberrypi/data/imx296_mono.json
> > @@ -5,7 +5,7 @@
> >          {
> >              "rpi.black_level":
> >              {
> > -                "black_level": 4096
> > +                "black_level": 3840
>
> Out of curiosity, what encoding is this one ? You mentioned 10-bits
> but this doesn't look like Q10, or is it ?
>

All our tuning parameters are specified in 16-bits, i.e. a white-point of
65535.
So the black level above is computed as 60 << (16bits - 10bits) == 3840.

Regards,
Naush


>
> >              }
> >          },
> >          {
> > --
> > 2.25.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20220928/2e9ade34/attachment.htm>