[libcamera-devel] [PATCH v1 1/1] utils: ipc: Update parser.py

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Apr 5 06:26:52 CEST 2023


Hi Harvey,

Thank you for the patch.

On Fri, Mar 31, 2023 at 08:45:45AM +0000, Harvey Yang via libcamera-devel wrote:
> Make the local mojom library the first priority in the sys path, to
> avoid mixing the local one with the system one in build.
> 
> Tested on chromebook soraka-libcamera.
> 
> Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>

I like small fixes :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  utils/ipc/parser.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/ipc/parser.py b/utils/ipc/parser.py
> index f46820fa..231a3266 100755
> --- a/utils/ipc/parser.py
> +++ b/utils/ipc/parser.py
> @@ -13,7 +13,7 @@ import sys
>  sys.dont_write_bytecode = True
>  
>  # Make sure that mojom_parser.py can import mojom
> -sys.path.append(f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')
> +sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')
>  
>  import mojo.public.tools.mojom.mojom_parser as parser

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list