[libcamera-devel] [PATCH v1 1/1] utils: ipc: Update parser.py

Han-lin Chen hanlinchen at google.com
Fri Apr 7 14:25:27 CEST 2023


Verified on ChromeOS.
Looks good to me.
Tested-by: Han-Lin Chen <hanlinchen at chromium.org>

On Wed, Apr 5, 2023 at 12:28 PM Paul Elder via libcamera-devel
<libcamera-devel at lists.libcamera.org> wrote:
>
> On Fri, Mar 31, 2023 at 08:45:45AM +0000, Harvey Yang via libcamera-devel wrote:
> > Make the local mojom library the first priority in the sys path, to
> > avoid mixing the local one with the system one in build.
> >
> > Tested on chromebook soraka-libcamera.
>
> Thanks for the fix.
>
> >
> > Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
>
> Looks good to me.
>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
>
> > ---
> >  utils/ipc/parser.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/utils/ipc/parser.py b/utils/ipc/parser.py
> > index f46820fa..231a3266 100755
> > --- a/utils/ipc/parser.py
> > +++ b/utils/ipc/parser.py
> > @@ -13,7 +13,7 @@ import sys
> >  sys.dont_write_bytecode = True
> >
> >  # Make sure that mojom_parser.py can import mojom
> > -sys.path.append(f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')
> > +sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')
> >
> >  import mojo.public.tools.mojom.mojom_parser as parser
> >
> > --
> > 2.40.0.348.gf938b09366-goog
> >



-- 
Cheers.
Hanlin Chen


More information about the libcamera-devel mailing list