[libcamera-devel] [PATCH] ipa: raspberrypi: agc: Add "shadows" constraint mode

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Apr 12 10:56:01 CEST 2023


Hi David,

Thank you for the patch.

On Tue, Apr 11, 2023 at 10:47:57AM +0100, David Plowman via libcamera-devel wrote:
> The "shadows" constraint mode actually exists in a number of tuning
> files, but had been omitted from the list of supported modes.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 9f3f3ac3..9c29fa9a 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -778,6 +778,7 @@ static const std::map<int32_t, std::string> MeteringModeTable = {
>  static const std::map<int32_t, std::string> ConstraintModeTable = {
>  	{ controls::ConstraintNormal, "normal" },
>  	{ controls::ConstraintHighlight, "highlight" },
> +	{ controls::ConstraintShadows, "shadows" },
>  	{ controls::ConstraintCustom, "custom" },
>  };
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list