[libcamera-devel] [PATCH 3/3] ipa: rkisp1: Add tuning files for PinephonePro sensors

Kieran Bingham kieran.bingham at ideasonboard.com
Mon Apr 24 22:21:11 CEST 2023


Quoting Robert Mader via libcamera-devel (2023-04-22 11:08:15)
> Tested-by: Robert Mader <robert.mader at collabora.com>
> 

As with the Chrometab, I think it's better to have these in as a
starting point than wait for an entire development of the algorithms to
be completed.

We can iteratively improve these, and also I think having them gives
others encouragement and a starting point as well.

I've already heard of someone purchasing a lux-meter and colour calibration
card to start investigating making improvements here on a PPP.

I think it's worth getting these in.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> On 06.03.23 18:24, Jacopo Mondi via libcamera-devel wrote:
> > Add to the RkISP1 data configuration files for the imx258 and ov8858
> > sensors found on Pine64 PinephonePro devices.
> >
> > The tuning file contain LSC tables extracted from the Rockchip Android
> > BSP the PinephonePro ships with.
> >
> > Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> > ---
> >   src/ipa/rkisp1/data/imx258.yaml | 54 +++++++++++++++++++++++++++++++++
> >   src/ipa/rkisp1/data/ov8858.yaml | 54 +++++++++++++++++++++++++++++++++
> >   2 files changed, 108 insertions(+)
> >   create mode 100644 src/ipa/rkisp1/data/imx258.yaml
> >   create mode 100644 src/ipa/rkisp1/data/ov8858.yaml
> >


More information about the libcamera-devel mailing list