[libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated SortIncludes in `.clang-format`

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Aug 1 10:41:15 CEST 2023


On Tue, Aug 01, 2023 at 09:21:02AM +0100, Kieran Bingham via libcamera-devel wrote:
> Hi Harvey,
> 
> Quoting Harvey Yang via libcamera-devel (2023-08-01 09:07:04)
> > `SortIncludes: true` was added in both ae05b9f and 0e1ff86, which caused
> > issues to run clang-format.
> > 
> 
> Yikes - this looks like it was my fault! Sorry!
> 
> But thanks for the cleanup / fix...
> 
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
> > ---
> >  .clang-format | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/.clang-format b/.clang-format
> > index 5b8857da..cac7029f 100644
> > --- a/.clang-format
> > +++ b/.clang-format
> > @@ -66,7 +66,6 @@ ExperimentalAutoDetectBinPacking: false
> >  FixNamespaceComments: true
> >  ForEachMacros:
> >    - 'udev_list_entry_foreach'
> > -SortIncludes: true
> >  IncludeBlocks: Regroup
> >  IncludeCategories:
> >    # Headers matching the name of the component are matched automatically.

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list