[libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add OV64A40 sensor properties

[Laurent Pinchart]

Hi Jacopo,

On Mon, Dec 04, 2023 at 10:06:35AM +0100, Jacopo Mondi wrote:
> On Tue, Nov 28, 2023 at 06:34:16PM +0200, Laurent Pinchart via libcamera-devel wrote:
> > On Tue, Nov 14, 2023 at 11:21:20AM +0100, Jacopo Mondi via libcamera-devel wrote:
> > > From: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > >
> > > Add an entry for the Omnivision OV64A40 Sensor which has a square pixel
> > > size of 1.008µm.
> > >
> > > Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > > Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> > > ---
> > >  src/libcamera/camera_sensor_properties.cpp | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> > > index 27d6799a2686..2ba2d9818c7f 100644
> > > --- a/src/libcamera/camera_sensor_properties.cpp
> > > +++ b/src/libcamera/camera_sensor_properties.cpp
> > > @@ -208,6 +208,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
> > >  				 */
> > >  			},
> > >  		} },
> > > +		{ "ov64a40", {
> > > +			.unitCellSize = { 1008, 1008 },
> >
> > Very precise :-)
> >
> > > +			.testPatternModes = {},
> >
> > The latest version of the drivers posted to the linux-media mailing list
> > doesn't implement the test pattern control, so this is right.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >
> > My understanding is that the sensor supports test patterns, and it seems
> > easy to implement. It's a very valuable feature, so when time permits,
> > it would be nice to add it.
> >
> 
> It would be indeed!
> 
> I have cooked up a patch for this, but things do not work as intended.
> I sent a request back to the camera module vendor for validation, but
> in the meantime I would prefere not to delay this one. WE can always
> add test patterns on top once clarified

That's fine with me. If you could add a /* TODO */ comment here (and if
possible also in the kernel driver) to record this, it would be great.

> > > +		} },
> > >  		{ "ov8858", {
> > >  			.unitCellSize = { 1120, 1120 },
> > >  			.testPatternModes = {

-- 
Regards,

Laurent Pinchart