[libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase process exit timeout

[Laurent Pinchart]

Hi Nicolas,

On Wed, Dec 06, 2023 at 04:10:30PM -0500, Nicolas Dufresne wrote:
> Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit :
> > When running tests on slower devices, 200ms is too low to wait for the
> > process to exit. Increase the timeout to 2s.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>

Thanks for the review. I made a mistake though, I meant to CC you (and
Vedant and Umang) on patch 6/6, not 5/6. Sorry about that.

> > ---
> >  test/ipc/unixsocket.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp
> > index 304e613bc984..1d4df28726cd 100644
> > --- a/test/ipc/unixsocket.cpp
> > +++ b/test/ipc/unixsocket.cpp
> > @@ -431,7 +431,7 @@ private:
> >  		if (ret)
> >  			return ret;
> >  
> > -		timeout.start(200ms);
> > +		timeout.start(2s);
> >  		while (!callDone_) {
> >  			if (!timeout.isRunning()) {
> >  				cerr << "Call timeout!" << endl;

-- 
Regards,

Laurent Pinchart