[libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls

Naushir Patuck naush at raspberrypi.com
Thu Dec 7 09:54:35 CET 2023


Hi David,

That's a good point, python will receive a binary blob which will need
interpreting.

Given this is a RPi vendor specific structure, I don't know if it's
appropriate (or indeed if it can even be done) to translate this in
the pybind11 wrapping thingy.  But this should be possible to do
somewhere in picamera2.

Regards,
Naush

On Wed, 6 Dec 2023 at 17:04, David Plowman
<david.plowman at raspberrypi.com> wrote:
>
> Hi Naush
>
> I think this is all great. The only thing I'd like to consider is how
> we can make this available to Python applications, which is where many
> (probably most) of our users are.
>
> Do we need to put some "vendor specific stuff" into the libcamera
> Python bindings to help interpret these structures?
>
> Arguably we could leave all that to Picamera2 but then it doesn't
> necessarily help every Python user. And also someone needs to do it!
>
> Any thoughts, anyone?
>
> David
>
> On Mon, 4 Dec 2023 at 16:18, Naushir Patuck via libcamera-devel
> <libcamera-devel at lists.libcamera.org> wrote:
> >
> > Hi,
> >
> > This patch series adds Raspberry Pi specific vendor controls, initially for
> > returning hardware generated statistics out in Request metdata.  This comes from
> > a user request at https://github.com/raspberrypi/libcamera/issues/90.
> >
> > Thanks,
> > Naush
> >
> > Naushir Patuck (2):
> >   build: controls: Add Raspberry Pi vendor specific controls
> >   ipa: vc4: Implement the StatsOutputEnable vendor control
> >
> >  include/libcamera/meson.build      |  1 +
> >  src/ipa/rpi/common/ipa_base.cpp    | 12 +++++++++---
> >  src/ipa/rpi/common/ipa_base.h      |  3 ++-
> >  src/ipa/rpi/vc4/vc4.cpp            |  6 ++++++
> >  src/libcamera/control_ids_rpi.yaml | 29 +++++++++++++++++++++++++++++
> >  5 files changed, 47 insertions(+), 4 deletions(-)
> >  create mode 100644 src/libcamera/control_ids_rpi.yaml
> >
> > --
> > 2.34.1
> >


More information about the libcamera-devel mailing list