[libcamera-devel] [PATCH 3/6] test: log: log_process: Improve debugging on process exit failures

Kieran Bingham kieran.bingham at ideasonboard.com
Thu Dec 7 17:28:42 CET 2023


Quoting Laurent Pinchart via libcamera-devel (2023-12-06 21:05:21)
> When the process fails to run and exit normally, the test prints an
> error message that provides little information:
> 
>         process did not exit normally
> 
> Expand the error message to print the exit status to make debugging
> easier.

Sounds helpful...

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  test/log/log_process.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp
> index f7635b70255c..fb6635cc99aa 100644
> --- a/test/log/log_process.cpp
> +++ b/test/log/log_process.cpp
> @@ -86,7 +86,8 @@ protected:
>                         dispatcher->processEvents();
>  
>                 if (exitStatus_ != Process::NormalExit) {
> -                       cerr << "process did not exit normally" << endl;
> +                       cerr << "process did not exit normally: " << exitStatus_
> +                            << endl;
>                         return TestFail;
>                 }
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>


More information about the libcamera-devel mailing list