[libcamera-devel] [PATCH 6/6] test: gstreamer: Remove videoconvert element from pipeline

[Umang Jain]

Hi Laurent,

On 12/7/23 2:35 AM, Laurent Pinchart via libcamera-devel wrote:
> The GStreamer single stream test uses the following pipeline:
>
> 	libcamerasrc ! videoconvert ! fakesink
>
> The videoconvert element isn't useful as the data is thrown away by the
> fakesink anyway. We can shorten the pipeline to
>
> 	libcamerasrc ! fakesink
>
> to save CPU time and to avoid depending on the gstreamer1.0-plugins-base
> package to run the unit tests.
>
> The test could be further simplified by replacing
> gst_parse_bin_from_description_full() with gst_element_factory_make(),
> now that we only add one element to the bin. The extra cost incurred by
> the bin only impacts initialization time, and using a bin will make it
> easier to add other elements in the future if needed. Keep the bin, and
> only drop the videoconvert element.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   test/gstreamer/gstreamer_single_stream_test.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp
> index a0dd12cfea84..301e4a935a37 100644
> --- a/test/gstreamer/gstreamer_single_stream_test.cpp
> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp
> @@ -29,7 +29,7 @@ protected:
>   		if (status_ != TestPass)
>   			return status_;
>   
> -		const gchar *streamDescription = "videoconvert ! fakesink";
> +		const gchar *streamDescription = "fakesink";
>   		g_autoptr(GError) error0 = NULL;
>   		stream0_ = gst_parse_bin_from_description_full(streamDescription, TRUE,
>   						NULL,