[libcamera-devel] [PATCH v1] libcamera: framebuffer_allocator: Remove unnecessary `clear()`

Barnabás Pőcze pobrn at protonmail.com
Sat Dec 9 03:22:28 CET 2023


The vector in question is destroyed when the item in the `buffers_` map
is destroyed as a result of the `erase()` call. A vector's destructor
already does all the things that `clear()` does,
so calling it earlier is not needed.

Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>
---
 src/libcamera/framebuffer_allocator.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp
index dabd9219..94389735 100644
--- a/src/libcamera/framebuffer_allocator.cpp
+++ b/src/libcamera/framebuffer_allocator.cpp
@@ -121,8 +121,6 @@ int FrameBufferAllocator::free(Stream *stream)
 	if (iter == buffers_.end())
 		return -EINVAL;
 
-	std::vector<std::unique_ptr<FrameBuffer>> &buffers = iter->second;
-	buffers.clear();
 	buffers_.erase(iter);
 
 	return 0;
-- 
2.43.0




More information about the libcamera-devel mailing list