[libcamera-devel] [RFC PATCH v2 4/7] libcamera: ipa: Soft IPA: add a Soft IPA implementation

[Andrey Konovalov]

On 12.12.2023 19:04, Kieran Bingham wrote:
> Quoting Pavel Machek via libcamera-devel (2023-12-12 15:51:10)
>> Hi!
>>
>>> Signed-off-by: Andrey Konovalov <andrey.konovalov at linaro.org>
>>
>> I'm not sure if we should call implementation "Linaro". Company name
>> seems misleading in this context. Could we call implementation "anna",
>> for example, after https://en.wikipedia.org/wiki/Anna_Atkins and
>> because it is first version, thus "A"?
> 
> I'd agree here ... I can't imagine libcamera want's "5 different
> competing softISP implementations.... all in the same code base"
> 
> This is just 'SoftISP' in my opinion.

Then SwIspLinaro could be merged into abstract SoftwareIsp,
the result being called just SoftwareIsp.
And SoftwareIspFactory* are not needed.
Correct?

Thanks,
Andrey

> --
> Kieran
> 
> 
>>
>> 1-4 Reviewed-by: Pavel Machek <pavel at ucw.cz>
>>
>> Best regards,
>>                                                          Pavel
>> -- 
>> People of Russia, stop Putin before his war on Ukraine escalates.