[libcamera-devel] [RFC PATCH v2 4/7] libcamera: ipa: Soft IPA: add a Soft IPA implementation

Pavel Machek pavel at ucw.cz
Wed Dec 13 22:19:35 CET 2023


Hi!

> >> ATM the statistics and debayer classes are mostly ready,
> >> but I need to merge this with Andrey's v2 RFC and
> >> then produce a clean new series from this
> >> (assuming people like the approach).
> > 
> > Ok, what about this one? I only converted half of the code, but the
> > other half of conversion should be very similar.
> > 
> > Compile-tested only as my sensor is bayer 8.
> > 
> > It makes it easier to see how we are skipping the low bits in 10P
> > bayer, and will make bayer 8 support easier, too, since the pixel_XXX
> > helpers are designed to be shared.
> 
> I have merged a variant of this with:
> 
> 1. The missing bits completed
> 2. Various renames to make it clear that the helpers are for 8bit bayer
>    sources (we are treating 10bpp packed as 8 bit here) and that
>    the output is bgr888 this should make life easier when adding
>    support for more input / output fmts.
> 
> Here is what I've merged / squashed:

Thanks a lot, looks good to me!

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20231213/c7c3c2b5/attachment.sig>


More information about the libcamera-devel mailing list