[libcamera-devel] statistics cleanup was Re: ... libcamera: ipa: Soft IPA: add a Soft IPA implementation

[Pavel Machek]

Hi!

> Note your implementation was broken because you were resetting
> the per frame stats every line. The idea is to use a local variable
> (hopefully a register) to gather the local r + g + b sums and
> then at the end of processing the entire line increase
> the per frame stats using the local variable.

Yes, I seen that optimalization, I just hoped that compiler is able to
this on its own when it has enough registers.

> I have merged / squashed a fixed version with some further cleanups:

Thank you, looks good.

Did we decide on the name? swisp_cpu or something like that was
mentioned, but perhaps we cpuisp is shorter and also should be unique
enough?

Best regards,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20231213/12bb56bc/attachment.sig>