[libcamera-devel] [RFC PATCH v2 4/7] libcamera: ipa: Soft IPA: add a Soft IPA implementation

[Andrey Konovalov]

Hi Hans,

On 14.12.2023 00:54, Hans de Goede wrote:
> Hi all,
> 
> On 12/12/23 22:38, Hans de Goede wrote:
> 
> <snip>
> 
>> Anyways if you have time, please take a look
>> at the swstats base class + linaro implementation
>> as well as at the debayer base class as well
>> as the DebayerCpu implementation of that:
>>
>> https://gitlab.freedesktop.org/camera/libcamera-softisp/-/tree/SoftwareISP-v02-hans2
>>
>> Which are the last few commits there.
>>
>> Note as I already mentioned I really need to merge
>> this with Andrey's latest v03 branch into a new
>> logical clean patch series suitable for upstream submission.
> 
> And as promised during our call today I now have
> a new v03 based branch ready integrating my
> put swstats and debayer into separate classes
> work (with the more optimized implementations):
> 
> https://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v03-hans1/
> 
> The big change compared to Andrey's SoftwareISP-v03 /
> RFC v2 posting is:
> 
> "libcamera: software_isp: Make swisp_linaro use the new DebayerCpu class"
> 
> Andrey, if you can take a look at this and let me know if those
> changes are ok with you that would be great.

Your changes look good to me.
And I do see significant fps increase for the higher resolutions on my target. Now
the fps reaches the frame rate from the camera sensor for all the resolutions - up
to the maximal 8M at 15Hz.

> The intend is to squash "Make swisp_linaro use the new DebayerCpu class"
> into the patch adding swisp_linaro before submitting a new series
> upstream.

Agreed.

> After the squashing the only item remaining before posting
> a new version upstream is renaming things away from using
> the linaro name for the current swisp and softipa implementations,
> I will do this rename tomorrow.

Sounds good!


Thanks,
Andrey

> Regards,
> 
> Hans
> 
> 
> 
>