[libcamera-devel] [PATCH 19/20] libcamera: skip until upstream resolves python 3.12 compatibility

[Laurent Pinchart]

On Fri, Dec 15, 2023 at 02:21:53PM +0100, Mattijs Korpershoek wrote:
> On ven., déc. 15, 2023 at 14:50, Laurent Pinchart via libcamera-devel wrote:
> > On Fri, Dec 15, 2023 at 01:04:02PM +0100, Alexander Kanavin via libcamera-devel wrote:
> >> That's right.
> >> 
> >> This page provides hints for how to replace usage of imp with
> >> equivalents in importlib:
> >> https://docs.python.org/3.11/library/imp.html
> >
> > The trouble is that the code in libcamera that uses imp isn't ours, it's
> > copied as-is from a third-party project. If we're lucky they will have
> > fixed the issue, and we can just take the latest version.
> 
> If this is in mojo, seems that chromium fixed it:
> https://chromium.googlesource.com/chromium/src/+/f5f6e361d037c31630661186e7bd7b31d2784cb8

Nice :-) Looks like we have a (hopefully easy) path forward.

Thank you for checking.

> >> On Fri, 15 Dec 2023 at 11:18, Kieran Bingham wrote:
> >> > Quoting Kieran Bingham (2023-12-15 10:16:20)
> >> > > +libcamera-devel mailing list
> >> > >
> >> > > Quoting Alexander Kanavin (2023-12-15 07:52:38)
> >> > > > I'd note that imp module has been deprecated for years, so that's what
> >> > > > happens when deprecation warnings are ignored.
> >
> > I haven't seen any warnings anywhere in the build process. Did I miss
> > them ?
> >
> >> > > Can you tell me more about what this issue is please? I'm not aware of
> >> > > it at all.
> >> > >
> >> > > > Signed-off-by: Alexander Kanavin <alex at linutronix.de>
> >> > > > ---
> >> > > >  meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb | 1 +
> >> > > >  .../packagegroups/packagegroup-meta-multimedia.bb               | 1 -
> >> > > >  meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.0.bb   | 2 +-
> >> > > >  3 files changed, 2 insertions(+), 2 deletions(-)
> >> > > >
> >> > > > diff --git a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb
> >> > > > index 2a3c6473e..9c04d7434 100644
> >> > > > --- a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb
> >> > > > +++ b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb
> >> > > > @@ -73,3 +73,4 @@ FILES:${PN}-gst = "${libdir}/gstreamer-1.0"
> >> > > >  # both 32 and 64 bit file APIs.
> >> > > >  GLIBC_64BIT_TIME_FLAGS = ""
> >> > > >
> >> > > > +SKIP_RECIPE[libcamera] ?= "Not compatible with python 3.12, see https://bugs.libcamera.org/show_bug.cgi?id=206"
> >> >
> >> > Aha, the clue was buried here.
> >> >
> >> > > > diff --git a/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb b/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb
> >> > > > index 672c8abc9..6ca4d539f 100644
> >> > > > --- a/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb
> >> > > > +++ b/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb
> >> > > > @@ -42,7 +42,6 @@ RDEPENDS:packagegroup-meta-multimedia = "\
> >> > > >      tearsofsteel-1080p \
> >> > > >      pipewire \
> >> > > >      ${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED", "commercial", bb.utils.contains("DISTRO_FEATURES", "x11", "projucer", "", d), "", d)} \
> >> > > > -    libcamera \
> >> > > >      vorbis-tools \
> >> > > >      libopenmpt \
> >> > > >      mimic \
> >> > > > diff --git a/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.0.bb b/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.0.bb
> >> > > > index b4da781f0..4d894349a 100644
> >> > > > --- a/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.0.bb
> >> > > > +++ b/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.0.bb
> >> > > > @@ -86,7 +86,7 @@ PACKAGECONFIG:class-target ??= " \
> >> > > >      ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd systemd-system-service systemd-user-service', '', d)} \
> >> > > >      ${@bb.utils.filter('DISTRO_FEATURES', 'alsa vulkan pulseaudio', d)} \
> >> > > >      ${PIPEWIRE_SESSION_MANAGER} \
> >> > > > -    ${FFMPEG_AVAILABLE} avahi flatpak gstreamer gsettings jack libusb pw-cat raop sndfile v4l2 udev volume webrtc-echo-cancelling libcamera readline \
> >> > > > +    ${FFMPEG_AVAILABLE} avahi flatpak gstreamer gsettings jack libusb pw-cat raop sndfile v4l2 udev volume webrtc-echo-cancelling readline \
> >> > > >  "
> >> > > >
> >> > > >  # "jack" and "pipewire-jack" packageconfigs cannot be both enabled,

-- 
Regards,

Laurent Pinchart