[libcamera-devel] [PATCH v3 0/8] ipa: rkisp1: Add autofocus algorithm

[Jacopo Mondi]

Hi Quentin

On Fri, Feb 03, 2023 at 10:42:03AM +0100, Quentin Schulz via libcamera-devel wrote:
> Date: Fri, 3 Feb 2023 10:42:03 +0100
> From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> To: Daniel Semkowicz <dse at thaumatec.com>,
>  libcamera-devel at lists.libcamera.org
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
>  Thunderbird/102.6.0
> Subject: Re: [libcamera-devel] [PATCH v3 0/8] ipa: rkisp1: Add autofocus
>  algorithm
>
> Hi all,
>
> Gentle ping here.
>

Sorry, I privately notified Daniel yesterday that his series has not
fallen into a (too deep) crack.

I'm in the process of setting up a [rockpi4 + imx519 + ak7375 lens] to
test it and will review it after.


> Cheers,
> Quentin
>
> On 1/19/23 09:41, Daniel Semkowicz via libcamera-devel wrote:
> > Hi!
> >
> > This is a patch series with a common AF algorithm implementation
> > basing on the IPU3 AF version. The common part was then used to
> > implement AF for the rkisp1 ISP.
> >
> > Early version of this serie was uploaded in the July, but there were
> > some change in the IPA in the meantime. The current version was updated
> > to the new IPA code and has most of the comments from the v2 review
> > fixed.
> >
> > Best regards
> > Daniel Semkowicz
> >
> > Daniel Semkowicz (8):
> >    rkisp1: Add camera lens to PH and expose it to the IPA
> >    rkisp1: Control camera lens position from IPA
> >    ipa: Add base class defining AF algorithm interface
> >    ipa: Add class that implements base AF control algorithm
> >    ipa: rkisp1: Add AF algorithm basing on common AfHillClimbing class
> >    pipeline: rkisp1: Add basic AF controls to the supported controls list
> >    ipa: rkisp1: Add "Windows" Metering mode to auto focus algorithm
> >    ipa: rkisp1: Add OV5675 tuning file
> >
> >   include/libcamera/ipa/rkisp1.mojom            |   2 +
> >   .../libipa/algorithms/af_hill_climbing.cpp    | 374 ++++++++++++++++++
> >   src/ipa/libipa/algorithms/af_hill_climbing.h  | 102 +++++
> >   src/ipa/libipa/algorithms/af_interface.cpp    |  92 +++++
> >   src/ipa/libipa/algorithms/af_interface.h      |  41 ++
> >   src/ipa/libipa/algorithms/meson.build         |  11 +
> >   src/ipa/libipa/meson.build                    |   6 +
> >   src/ipa/rkisp1/algorithms/af.cpp              | 182 +++++++++
> >   src/ipa/rkisp1/algorithms/af.h                |  51 +++
> >   src/ipa/rkisp1/algorithms/meson.build         |   1 +
> >   src/ipa/rkisp1/data/meson.build               |   1 +
> >   src/ipa/rkisp1/data/ov5675.yaml               |  20 +
> >   src/ipa/rkisp1/ipa_context.h                  |   5 +
> >   src/ipa/rkisp1/rkisp1.cpp                     |  23 ++
> >   src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  21 +
> >   15 files changed, 932 insertions(+)
> >   create mode 100644 src/ipa/libipa/algorithms/af_hill_climbing.cpp
> >   create mode 100644 src/ipa/libipa/algorithms/af_hill_climbing.h
> >   create mode 100644 src/ipa/libipa/algorithms/af_interface.cpp
> >   create mode 100644 src/ipa/libipa/algorithms/af_interface.h
> >   create mode 100644 src/ipa/libipa/algorithms/meson.build
> >   create mode 100644 src/ipa/rkisp1/algorithms/af.cpp
> >   create mode 100644 src/ipa/rkisp1/algorithms/af.h
> >   create mode 100644 src/ipa/rkisp1/data/ov5675.yaml
> >