[libcamera-devel] [PATCH] meson: libcamera: Report IPA signature method

[Umang Jain]

Hi,

On 2/7/23 12:10 AM, Laurent Pinchart via libcamera-devel wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Mon, Jan 30, 2023 at 10:54:35PM +0000, Kieran Bingham via libcamera-devel wrote:
>> Use the Configuration section to report which dependency is used to
>> handle IPA module signatures.
>>
>> In the event that it is not found, report directly in the configuration
>> that modules are Isolated.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>> ---
>>   src/libcamera/meson.build | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
>> index 9869bfe77c78..dbf7f016e1b4 100644
>> --- a/src/libcamera/meson.build
>> +++ b/src/libcamera/meson.build
>> @@ -90,6 +90,9 @@ endif
>>   
>>   if not libcrypto.found()
>>       warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')
>> +    summary({'IPA Signatures': 'Isolated'}, section: 'Configuration')
> s/Signatures/signatures/ to match the other summary entries.
>
>> +else
>> +    summary({'IPA Signatures': libcrypto.name()}, section: 'Configuration')
> Same here.
>
>>   endif
> Clearly nitpicking, "IPA Signatures: Isolated" sounds a bit weird. How
> about
>
>      summary({'IPA modules signed with': 'None (modules will run isolated)'}, section: 'Configuration')

One related term is 'sandbox' so few suggestions below:

     summary({'IPA modules signed with': 'None (modules will run in sandbox)'}, section: 'Configuration')
     summary({'IPA modules signed with': 'None (modules will be sandboxed)'}, section: 'Configuration')


> else
>      summary({'IPA modules signed with': libcrypto.name()}, section: 'Configuration')
> endif
>
> Feel free to adjust or keep your original version.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

>
>>   
>>   if liblttng.found()