[libcamera-devel] [PATCH v1 1/4] libcamera: camera_sensor: Demote flip support message to Debug

Umang Jain umang.jain at ideasonboard.com
Wed Feb 8 11:25:26 CET 2023


Hi Laurent,

Thank you for the patch

On 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote:
> The CameraSensor::validateSensorDriver() function prints a Warning
> message when the camera sensor doesn't support flips. We don't mandate
> flip support and can run without it without any problem, so a warning is
> too harsh. Demote it to a Debug message.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/libcamera/camera_sensor.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index b772337eb44a..11117502d817 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -261,7 +261,7 @@ int CameraSensor::validateSensorDriver()
>   		supportFlips_ = true;
>   
>   	if (!supportFlips_)
> -		LOG(CameraSensor, Warning)
> +		LOG(CameraSensor, Debug)
>   			<< "Camera sensor does not support horizontal/vertical flip";
>   
>   	/*



More information about the libcamera-devel mailing list