[libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in validateColorSpaces

[David Plowman]

Hi Laurent

Ah yes, forgot about "fixes" tags. Let me try again...!

Thanks
David

On Mon, 13 Feb 2023 at 10:12, Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> Hi David,
>
> Thank you for the patch.
>
> On Mon, Feb 13, 2023 at 09:19:34AM +0000, David Plowman via
> libcamera-devel wrote:
> > This fixes a small error in the validateColorSpaces method where the
> > colour space was not being set to Raw if it had an "unset" (null
> > option) value.
>
> Should this have a Fixes: tag ?
>
> > Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> > ---
> >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > index c0dd9551..84120954 100644
> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > @@ -449,10 +449,9 @@ CameraConfiguration::Status
> RPiCameraConfiguration::validateColorSpaces([[maybe_
> >               /* First fix up raw streams to have the "raw" colour
> space. */
> >               if (isRaw(cfg.pixelFormat)) {
> >                       /* If there was no value here, that doesn't count
> as "adjusted". */
> > -                     if (cfg.colorSpace && cfg.colorSpace !=
> ColorSpace::Raw) {
> > +                     if (cfg.colorSpace && cfg.colorSpace !=
> ColorSpace::Raw)
> >                               status = Adjusted;
> > -                             cfg.colorSpace = ColorSpace::Raw;
> > -                     }
> > +                     cfg.colorSpace = ColorSpace::Raw;
> >                       continue;
> >               }
> >
>
> --
> Regards,
>
> Laurent Pinchart
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20230213/96d72c63/attachment.htm>