[libcamera-devel] [PATCH 0/3] libcamera: rkisp1: Fix generateConfiguration

Jacopo Mondi jacopo.mondi at ideasonboard.com
Tue Feb 21 17:45:01 CET 2023


The series started with bug 180:
https://bugs.libcamera.org/show_bug.cgi?id=180

which reports how using the self-path for generating a configuration
for a single stream results in only StreamFormats up to 1920x1920
to be produced.

I have then noticed how the current implementation of
RkISP1Path::generateConfiguration() could produce unusual sizes, such as
1920x1432 in case the sensor's resolution is larger than the maximum supported
1920x1920 output.

Finally, if StillCapture is requested, make sure it is assigned to the main
path in RkISP1::generateConfiguration() to make sure it can produce images
in full resolution.

Tested on Pinephone Pro with imx258 camera.

Jacopo Mondi (3):
  libcamera: rkisp1: Generate config using main path
  libcamera: rkisp1: Assign sizes to roles
  libcamera: rkisp1: Reserve main path for StillCapture

 src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 36 +++++++++++++------
 src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 11 +++---
 src/libcamera/pipeline/rkisp1/rkisp1_path.h   |  1 +
 3 files changed, 33 insertions(+), 15 deletions(-)

--
2.39.0



More information about the libcamera-devel mailing list