[libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor tuning updates

[Naushir Patuck]

Hi Paul,

On Tue, 28 Feb 2023 at 09:58, Paul Elder via libcamera-devel
<libcamera-devel at lists.libcamera.org> wrote:
>
> On Wed, Feb 22, 2023 at 04:23:55PM +0000, David Plowman via libcamera-devel wrote:
> > Date: Wed, 22 Feb 2023 16:23:55 +0000
> > From: David Plowman <david.plowman at raspberrypi.com>
> > To: libcamera-devel at lists.libcamera.org
> > Subject: [PATCH] ipa: raspberrypi: imx296: Minor tuning updates
> > X-Mailer: git-send-email 2.30.2
> >
> > Some small updates to the tuning for the imx296 colour sensor:
> >
> > * Minor colour changes, generally makes things a little less green
> > * Sharpening toned down
> > * rpi.focus algorithm added so that focus measure can be accessed.
> >
> > The sharpening and focus changes are also made for the mono version of
> > the sensor. The sharpness characteristics should be very similar so
> > the change should beneficial, and the addition of the focus measure
> > may be useful, and is at worst harmless.
> >
> > Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> > ---
> >  src/ipa/raspberrypi/data/imx296.json      | 20 ++++++++++++++------
> >  src/ipa/raspberrypi/data/imx296_mono.json | 12 ++++++++++--
> >  2 files changed, 24 insertions(+), 8 deletions(-)
> >
> > diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json
> > index 4e830517..2ced95e2 100644
> > --- a/src/ipa/raspberrypi/data/imx296.json
> > +++ b/src/ipa/raspberrypi/data/imx296.json
> > @@ -78,7 +78,7 @@
> >                      "auto":
> >                      {
> >                          "lo": 2500,
> > -                        "hi": 8000
> > +                        "hi": 7600
> >                      },
> >                      "incandescent":
> >                      {
> > @@ -108,7 +108,7 @@
> >                      "cloudy":
> >                      {
> >                          "lo": 7000,
> > -                        "hi": 8600
> > +                        "hi": 7600
> >                      }
> >                  },
> >                  "bayes": 1,
> > @@ -122,8 +122,8 @@
> >                      5600.0, 0.2948, 0.6124,
> >                      7400.0, 0.2336, 0.6894
> >                  ],
> > -                "sensitivity_r": 1.0,
> > -                "sensitivity_b": 1.0,
> > +                "sensitivity_r": 1.05,
> > +                "sensitivity_b": 1.05,
> >                  "transverse_pos": 0.03093,
> >                  "transverse_neg": 0.02374
> >              }
> > @@ -418,7 +418,15 @@
> >              }
> >          },
> >          {
> > -            "rpi.sharpen": { }
> > +            "rpi.sharpen":
> > +         {
> > +             "threshold": 0.1,
> > +             "strength": 1.0,
> > +             "limit": 0.18
> > +         }
>
> I think you're mixing tabs and spaces here.
>
> > +        },
> > +        {
> > +            "rpi.focus": { }
> >          }
> >      ]
> > -}
> > \ No newline at end of file
> > +}
> > diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json
> > index b68b11db..d937bb30 100644
> > --- a/src/ipa/raspberrypi/data/imx296_mono.json
> > +++ b/src/ipa/raspberrypi/data/imx296_mono.json
> > @@ -222,7 +222,15 @@
> >              }
> >          },
> >          {
> > -            "rpi.sharpen": { }
> > +            "rpi.sharpen":
> > +         {
> > +             "threshold": 0.1,
> > +             "strength": 1.0,
> > +             "limit": 0.18
> > +         }
>
> Also here.
>
> Otherwise, looks good to me.
>
> Acked-by: Paul Elder <paul.elder at ideasonboard.com>

Thanks for spotting that!

We might also want to do one or two more shoots before finalising the numbers.
We will fix this as well and submit the final version shortly.

Regards,
Naush



>
> > +        },
> > +        {
> > +            "rpi.focus": { }
> >          }
> >      ]
> > -}
> > \ No newline at end of file
> > +}
> > --
> > 2.30.2
> >