[libcamera-devel] [PATCH v1 13/14] libcamera: camera_sensor: Add Sony IMX708 sensor properties

[Kieran Bingham]

Quoting Naushir Patuck via libcamera-devel (2023-01-19 10:45:43)
> From: Nick Hollinghurst <nick.hollinghurst at raspberrypi.com>
> 
> The IMX708 sensor driver advertises its module variants (narrow/wide angle lens,
> IR block/pass) by modifying the media entity name string. So add duplicate
> entries for each variant.

The duplication here is a bit of a pain. Are there any sensor properties
we might register that would change in each of these variants?

Or should we make the CameraSensorProperties class more intelligent so
it just does the lookup on the sensor only. Of course ideally we should
be able to identify the sensor and the variant separately from the
kernel - which might not be possible right now - in which case, given
how little information is actually duplicated here I'd be fine with this
for now.


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Nick Hollinghurst <nick.hollinghurst at raspberrypi.com>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  src/libcamera/camera_sensor_properties.cpp | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index c3c2caced906..3afd500ea3be 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -123,6 +123,22 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                                  */
>                         },
>                 } },
> +               { "imx708", {
> +                       .unitCellSize = { 1400, 1400 },
> +                       .testPatternModes = {},
> +               } },
> +               { "imx708_noir", {
> +                       .unitCellSize = { 1400, 1400 },
> +                       .testPatternModes = {},
> +               } },
> +               { "imx708_wide", {
> +                       .unitCellSize = { 1400, 1400 },
> +                       .testPatternModes = {},
> +               } },
> +               { "imx708_wide_noir", {
> +                       .unitCellSize = { 1400, 1400 },
> +                       .testPatternModes = {},
> +               } },
>                 { "ov2740", {
>                         .unitCellSize = { 1400, 1400 },
>                         .testPatternModes = {
> -- 
> 2.25.1
>