[libcamera-devel] [PATCH 4/4] ipa: rkisp1: Raise maximum analogue gain

Mikhail Rudenko mike.rudenko at gmail.com
Thu Jan 19 16:59:05 CET 2023


Omnivision OV4689 sensor driver exposes maximum analogue gain of
16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can
be used.

Signed-off-by: Mikhail Rudenko <mike.rudenko at gmail.com>
---
 src/ipa/rkisp1/algorithms/agc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
index e3470e25..e4cb2fc7 100644
--- a/src/ipa/rkisp1/algorithms/agc.cpp
+++ b/src/ipa/rkisp1/algorithms/agc.cpp
@@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc)
 
 /* Limits for analogue gain values */
 static constexpr double kMinAnalogueGain = 1.0;
-static constexpr double kMaxAnalogueGain = 8.0;
+static constexpr double kMaxAnalogueGain = 16.0;
 
 /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */
 static constexpr utils::Duration kMaxShutterSpeed = 60ms;
-- 
2.39.0



More information about the libcamera-devel mailing list