[libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning file

[Jacopo Mondi]

Hi Mikhail

On Thu, Jan 19, 2023 at 06:59:04PM +0300, Mikhail Rudenko via libcamera-devel wrote:
> Add a minimal tuning file for Omnivision OV4689, specifying black
> level subtraction level.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko at gmail.com>
> ---
>  src/ipa/rkisp1/data/meson.build |  1 +
>  src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++
>  2 files changed, 14 insertions(+)
>  create mode 100644 src/ipa/rkisp1/data/ov4689.yaml
>
> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> index c3b4e388..f5e9fa75 100644
> --- a/src/ipa/rkisp1/data/meson.build
> +++ b/src/ipa/rkisp1/data/meson.build
> @@ -2,6 +2,7 @@
>
>  conf_files = files([
>      'imx219.yaml',
> +    'ov4689.yaml',
>      'ov5640.yaml',
>      'uncalibrated.yaml',
>  ])
> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml
> new file mode 100644
> index 00000000..750b369e
> --- /dev/null
> +++ b/src/ipa/rkisp1/data/ov4689.yaml
> @@ -0,0 +1,13 @@
> +# SPDX-License-Identifier: CC0-1.0
> +%YAML 1.1
> +---
> +version: 1
> +algorithms:
> +  - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +      R:  64
> +      Gr: 64
> +      Gb: 64
> +      B:  64

Are these values measured ?

In such case
Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

Thanks
  j

> +...
> --
> 2.39.0
>