[libcamera-devel] [PATCH] qcam: Decrease minimum width of selector dialog

[Kieran Bingham]

Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)
> On phone screens the default width is too wide, so the OK button cannot
> be clicked.
> 
> Fix this by decreasing the minimum size of the dialog so it fits nicely.
> 
> Signed-off-by: Luca Weiss <luca at z3ntu.xyz>
> ---
>  src/apps/qcam/cam_select_dialog.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/apps/qcam/cam_select_dialog.cpp b/src/apps/qcam/cam_select_dialog.cpp
> index 3c8b12a9..2a600383 100644
> --- a/src/apps/qcam/cam_select_dialog.cpp
> +++ b/src/apps/qcam/cam_select_dialog.cpp
> @@ -25,6 +25,9 @@ CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager *cameraManag
>         /* Use a QFormLayout for the dialog. */
>         QFormLayout *layout = new QFormLayout(this);
>  
> +       /* Decrease minimum width of dialog to fit on narrow screens */
> +       setMinimumSize(250, 100);
> +

This looks reasonable, and when applying here - it doesn't break my
view, but my screen is large.

Is there any way to reproduce this issue otherwise? I suspect not easily
without getting a small screen. But to me this is ok.


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>         /* Setup the camera id combo-box. */
>         cameraIdComboBox_ = new QComboBox;
>         for (const auto &cam : cm_->cameras())
> -- 
> 2.39.1
>