[libcamera-devel] [PATCH v3 1/3] include: base: Do not install private headers

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Tue, Jul 04, 2023 at 03:24:33PM +0100, Kieran Bingham via libcamera-devel wrote:
> Split the public and private headers from the base library and stop installing
> private headers as part of the install process.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/base/meson.build | 28 ++++++++++++++++++----------
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build
> index 4410aba8181a..ee91bd1e0071 100644
> --- a/include/libcamera/base/meson.build
> +++ b/include/libcamera/base/meson.build
> @@ -2,31 +2,39 @@
>  
>  libcamera_base_include_dir = libcamera_include_dir / 'base'
>  
> -libcamera_base_headers = files([
> -    'backtrace.h',
> +libcamera_base_public_headers = files([
>      'bound_method.h',
>      'class.h',
>      'compiler.h',
> +    'flags.h',
> +    'object.h',
> +    'shared_fd.h',
> +    'signal.h',
> +    'span.h',
> +    'thread_annotations.h',
> +    'unique_fd.h',
> +])
> +
> +libcamera_base_private_headers = files([
> +    'backtrace.h',
>      'event_dispatcher.h',
>      'event_dispatcher_poll.h',
>      'event_notifier.h',
>      'file.h',
> -    'flags.h',
>      'log.h',
>      'message.h',
>      'mutex.h',
> -    'object.h',
>      'private.h',
>      'semaphore.h',
> -    'shared_fd.h',
> -    'signal.h',
> -    'span.h',
>      'thread.h',
> -    'thread_annotations.h',
>      'timer.h',
> -    'unique_fd.h',
>      'utils.h',
>  ])
>  
> -install_headers(libcamera_base_headers,
> +libcamera_base_headers = [
> +    libcamera_base_public_headers,
> +    libcamera_base_private_headers,
> +]
> +
> +install_headers(libcamera_base_public_headers,
>                  subdir: libcamera_base_include_dir)

-- 
Regards,

Laurent Pinchart