[libcamera-devel] [PATCH] libcamera: base: Move thread_annotations to private

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jul 4 21:16:00 CEST 2023


Hi Kieran,

Thank you for the patch.

On Tue, Jul 04, 2023 at 08:08:49PM +0100, Kieran Bingham via libcamera-devel wrote:
> The libcamera thread annotations are for internal use only and are
> not part of any public api. Mark the header accordingly by including the

s/api/API/

> private.h header guard.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/base/thread_annotations.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h
> index e81929f674d7..25b3c7b6cf92 100644
> --- a/include/libcamera/base/thread_annotations.h
> +++ b/include/libcamera/base/thread_annotations.h
> @@ -7,6 +7,8 @@
>  
>  #pragma once
>  
> +#include <libcamera/base/private.h>
> +
>  /*
>   * Enable thread safety attributes only with clang.
>   * The attributes can be safely erased when compiling with other compilers.

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list