[libcamera-devel] [master/kirkstone][PATCH v3 2/3] libcamera: Add support for TI CSI-RX

[Kieran Bingham]

Hi Jai,

Quoting Jai Luthra (2023-07-06 05:16:51)
> TI's CSI-RX driver is not yet upstream, so the libcamera simple pipeline
> does not recognize it.
> 

Has this driver been posted to the linux-media mailing list?


> Apply a patch to the simple pipeline so that it can recognize the media
> entity for TI's CSI-RX driver.
> 
> Signed-off-by: Jai Luthra <j-luthra at ti.com>
> ---
> 
> v3: Add Upstream-Status tag
> Link to v2: https://lore.kernel.org/all/20230706035522.1817402-2-j-luthra@ti.com/
> 
>  .../0001-simple-Support-TI-CSI-RX.patch       | 33 +++++++++++++++++++
>  .../libcamera/libcamera_0.0.5.bb              |  1 +
>  2 files changed, 34 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch
> 
> diff --git a/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch b/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch
> new file mode 100644
> index 00000000..82b02200
> --- /dev/null
> +++ b/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch
> @@ -0,0 +1,33 @@
> +From d0e4f4f224671e9fc992d39e7beb9c486303ede1 Mon Sep 17 00:00:00 2001
> +From: Jai Luthra <j-luthra at ti.com>
> +Date: Thu, 23 Mar 2023 11:38:46 +0530
> +Subject: [PATCH] simple: Support TI CSI-RX
> +
> +Add support for TI's CSI-RX pixel grabber device for the simple
> +pipeline.
> +
> +The driver is not yet merged, but v7 is posted [1] upstream.
> +
> +Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]

I'll take that as a yes!

> +Upstream-Status: Pending
> +Signed-off-by: Jai Luthra <j-luthra at ti.com>
> +---
> + src/libcamera/pipeline/simple/simple.cpp | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> +index e1f8b989..520405a1 100644
> +--- a/src/libcamera/pipeline/simple/simple.cpp
> ++++ b/src/libcamera/pipeline/simple/simple.cpp
> +@@ -194,6 +194,8 @@ static const SimplePipelineInfo supportedDevices[] = {
> +       { "mxc-isi", {} },
> +       { "qcom-camss", {} },
> +       { "sun6i-csi", {} },
> ++      { "j721e-csi2rx", {} },


So this line could already be merged to libcamera directly.

Could you post this patch to the libcamera mailing list please?
(libcamera-devel at lists.libcamera.org).

I'm planning the next release of libcamera in the next week - and I
believe we could get this in quite quickly.

--
Regards

Kieran

> ++
> + };
> + 
> + } /* namespace */
> +-- 
> +2.41.0
> +
> diff --git a/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb b/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb
> index 6ad376f2..b2eb5fac 100644
> --- a/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb
> +++ b/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb
> @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "\
>  
>  SRC_URI = " \
>          git://git.libcamera.org/libcamera/libcamera.git;protocol=https;branch=master \
> +        file://0001-simple-Support-TI-CSI-RX.patch \
>  "
>  
>  SRCREV = "fb44403f1c5571549ac128c21daee9761eb9249c"
> -- 
> 2.41.0
> 
>