[libcamera-devel] [PATCH] libcamera: pipeline: simple: Support TI CSI-RX

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Jul 6 21:11:22 CEST 2023


Hi Jai,

Thank you for the patch.

On Thu, Jul 06, 2023 at 11:44:47PM +0530, Jai Luthra wrote:
> New TI SoCs from J7 and AM62 family have a camera pipeline that receives
> data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim"
> IP routes this incoming stream of data to the DMA subsystem, to finally
> store the frame data in memory.
> 
> The driver for this is not merged in mainline yet, but v7 was posted [1]
> on linux-media list a few months ago.
> 
> With some minor fixes, the work-in-progress v8 series [2] works with the
> simple pipeline handler, so we enable support for this device.
> 
> Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]
> Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2]
> Signed-off-by: Jai Luthra <j-luthra at ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
> I am planning to post the v8 series for review upstream in the coming few 
> weeks.
> 
> Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt
> 
>  src/libcamera/pipeline/simple/simple.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 7495587c..05ba76bc 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -192,6 +192,7 @@ namespace {
>  static const SimplePipelineInfo supportedDevices[] = {
>  	{ "dcmipp", {} },
>  	{ "imx7-csi", { { "pxp", 1 } } },
> +	{ "j721e-csi2rx", {} },
>  	{ "mxc-isi", {} },
>  	{ "qcom-camss", {} },
>  	{ "sun6i-csi", {} },

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list