[libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all colour shading
Nick Hollinghurst
nick.hollinghurst at raspberrypi.com
Fri Jul 7 14:21:54 CEST 2023
Thanks, Naush
This is clearly the right thing to do for a mono sensor, to avoid scaling
it as Bayer, which previously introduced checkerboard artifacts.
(The error was small, because the smallest value for each component gets
normalized to 1.0 and the variation was not large, but was still quite
visible in JPEGs.)
Reviewed-by: Nick Hollinghurst <nick.hollinghurst at raspberrypi.com>
Nick
On Fri, 7 Jul 2023 at 12:03, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> Adding Nick for a review as well.
>
> On Fri, 7 Jul 2023 at 11:37, Naushir Patuck <naush at raspberrypi.com> wrote:
> >
> > Colour shading should be turned off for the mono variant of the IMX296
> > sensor. To do this, set all the colour gain coefficients to 1.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > ---
> > src/ipa/rpi/vc4/data/imx296_mono.json | 48 +++++++++++++--------------
> > 1 file changed, 24 insertions(+), 24 deletions(-)
> >
> > diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json
b/src/ipa/rpi/vc4/data/imx296_mono.json
> > index 955af43cccff..d4140c81bf0d 100644
> > --- a/src/ipa/rpi/vc4/data/imx296_mono.json
> > +++ b/src/ipa/rpi/vc4/data/imx296_mono.json
> > @@ -123,18 +123,18 @@
> > "ct": 4000,
> > "table":
> > [
> > - 2.554, 2.554, 2.541, 2.534, 2.495, 2.506,
2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,
> > - 2.522, 2.534, 2.539, 2.531, 2.531, 2.506,
2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,
> > - 2.509, 2.517, 2.534, 2.529, 2.531, 2.521,
2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,
> > - 2.507, 2.508, 2.517, 2.516, 2.495, 2.487,
2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,
> > - 2.509, 2.517, 2.507, 2.501, 2.494, 2.519,
2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,
> > - 2.521, 2.522, 2.476, 2.501, 2.501, 2.539,
2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,
> > - 2.516, 2.519, 2.469, 2.499, 2.499, 2.543,
2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,
> > - 2.509, 2.515, 2.465, 2.487, 2.487, 2.539,
2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,
> > - 2.499, 2.499, 2.475, 2.482, 2.471, 2.509,
2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,
> > - 2.499, 2.488, 2.488, 2.488, 2.471, 2.462,
2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,
> > - 2.483, 2.484, 2.488, 2.488, 2.502, 2.496,
2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,
> > - 2.483, 2.487, 2.478, 2.478, 2.507, 2.509,
2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1
> > ]
> > }
> > ],
> > @@ -143,18 +143,18 @@
> > "ct": 4000,
> > "table":
> > [
> > - 2.619, 2.603, 2.599, 2.597, 2.595, 2.594,
2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,
> > - 2.619, 2.615, 2.603, 2.601, 2.596, 2.595,
2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,
> > - 2.617, 2.617, 2.612, 2.611, 2.604, 2.598,
2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,
> > - 2.624, 2.619, 2.615, 2.612, 2.605, 2.602,
2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,
> > - 2.629, 2.627, 2.627, 2.617, 2.609, 2.598,
2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,
> > - 2.629, 2.632, 2.637, 2.627, 2.612, 2.612,
2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,
> > - 2.635, 2.636, 2.642, 2.628, 2.623, 2.623,
2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,
> > - 2.641, 2.639, 2.646, 2.632, 2.627, 2.625,
2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,
> > - 2.643, 2.644, 2.651, 2.649, 2.629, 2.617,
2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,
> > - 2.645, 2.646, 2.649, 2.649, 2.638, 2.624,
2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,
> > - 2.641, 2.643, 2.649, 2.647, 2.638, 2.618,
2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,
> > - 2.638, 2.637, 2.647, 2.634, 2.634, 2.618,
2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1,
> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1
> > ]
> > }
> > ],
> > --
> > 2.34.1
> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20230707/dde25fa5/attachment.htm>
More information about the libcamera-devel
mailing list