[libcamera-devel] [PATCH] README.rst: Report py dependencies

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jul 25 13:43:26 CEST 2023


Hi Kieran,

Thank you for the patch.

On Fri, Jul 21, 2023 at 07:20:56AM +0100, Kieran Bingham via libcamera-devel wrote:
> The python bindings were supported by a subproject when they were first

s/python/Python/

> contributed to be able to directly make use of the smart pointers
> branch.
> 
> This requirement has now been removed to prefer using released versions
> of pybind11 directly, however the README.rst was not updated to
> reference and reflect this.
> 
> Update the README.rst to report the pybind11 package which needs to be
> installed to make use of the optional python bindings component.

Ditto.

> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  README.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index df2818e1f598..18946e4f5ca2 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -101,6 +101,9 @@ for tracing with lttng: [optional]
>  for android: [optional]
>          libexif-dev libjpeg-dev
>  
> +for python bindings: [optional]

And here too.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +        pybind11-dev
> +
>  for lc-compliance: [optional]
>          libevent-dev
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list