[libcamera-devel] [PATCH] ipa: rpi: imx296: Small refinements to the IMX296 mono sensor tuning

[Laurent Pinchart]

Hi Naush,

Thank you for the patch.

On Thu, Jun 01, 2023 at 02:08:51PM +0100, Naushir Patuck via libcamera-devel wrote:
> Update the noise profile and reference lux level with newly taken
> calibration pictures. Remove GEQ/cross-talk processing block as this is
> a mono sensor.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/rpi/vc4/data/imx296_mono.json | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json
> index 30965b4b8d61..db020550d70e 100644
> --- a/src/ipa/rpi/vc4/data/imx296_mono.json
> +++ b/src/ipa/rpi/vc4/data/imx296_mono.json
> @@ -14,25 +14,18 @@
>          {
>              "rpi.lux":
>              {
> -                "reference_shutter_speed": 19184,
> +                "reference_shutter_speed": 9998,
>                  "reference_gain": 1.0,
>                  "reference_aperture": 1.0,
> -                "reference_lux": 432,
> -                "reference_Y": 13773
> +                "reference_lux": 823,
> +                "reference_Y": 12396
>              }
>          },
>          {
>              "rpi.noise":
>              {
>                  "reference_constant": 0,
> -                "reference_slope": 2.957
> -            }
> -        },
> -        {
> -            "rpi.geq":
> -            {
> -                "offset": 185,
> -                "slope": 0.0105
> +                "reference_slope": 2.753
>              }
>          },
>          {

-- 
Regards,

Laurent Pinchart