[libcamera-devel] [PATCH v5 07/13] py: simple-continuous-capture.py: Use new events support

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Sat, Jun 03, 2023 at 10:56:09AM +0300, Tomi Valkeinen wrote:
> Update simple-continuous-capture.py to the new event model.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/py/examples/simple-continuous-capture.py | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py
> index e1cb931e..37ca623c 100755
> --- a/src/py/examples/simple-continuous-capture.py
> +++ b/src/py/examples/simple-continuous-capture.py
> @@ -83,16 +83,17 @@ class CaptureContext:
>      camera_contexts: list[CameraCaptureContext] = []
>  
>      def handle_camera_event(self):
> -        # cm.get_ready_requests() returns the ready requests, which in our case
> -        # should almost always return a single Request, but in some cases there
> -        # could be multiple or none.
> +        # cm.get_events() returns the ready events, which in our case should
> +        # almost always be a single RequestCompleted event, but in some cases
> +        # there could be multiple ones, other events, or no events at all.

Same comment as for 06/13.

>  
> -        reqs = self.cm.get_ready_requests()
> +        for ev in self.cm.get_events():
> +            # We are only interested in RequestCompleted events
> +            if ev.type != libcam.Event.Type.RequestCompleted:
> +                continue
>  
> -        # Process the captured frames
> -
> -        for req in reqs:
> -            self.handle_request(req)
> +            # Process the captured frames
> +            self.handle_request(ev.request)
>  
>          return True
>  

-- 
Regards,

Laurent Pinchart