[libcamera-devel] [PATCH v3 1/5] libcamera: internal: request: convert to pragma once

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Mon, May 15, 2023 at 01:45:46PM +0100, Kieran Bingham via libcamera-devel wrote:
> Remove the verbose #ifndef/#define/#endif pattern for maintaining
> header idempotency, and replace it with a simple #pragma once.
> 
> This simplifies the headers, and prevents redundant changes when
> header files get moved.
> 
> The internal/request.h was missed at the time of the original
> conversion. Update it.
> 
> Fixes: df131ad08893 ("libcamera: internal: Convert to pragma once")
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/internal/request.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h
> index 8c92a27a95e5..3454cf5a72f5 100644
> --- a/include/libcamera/internal/request.h
> +++ b/include/libcamera/internal/request.h
> @@ -4,8 +4,8 @@
>   *
>   * request.h - Request class private data
>   */
> -#ifndef __LIBCAMERA_INTERNAL_REQUEST_H__
> -#define __LIBCAMERA_INTERNAL_REQUEST_H__
> +
> +#pragma once
>  
>  #include <chrono>
>  #include <map>
> @@ -62,5 +62,3 @@ private:
>  };
>  
>  } /* namespace libcamera */
> -
> -#endif /* __LIBCAMERA_INTERNAL_REQUEST_H__ */

-- 
Regards,

Laurent Pinchart