[libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide a Devices camera property

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Mon, May 15, 2023 at 01:45:49PM +0100, Kieran Bingham via libcamera-devel wrote:
> Provide a new Camera property that allows pipeline handlers to list any
> devices used to operate the device. This allows other frameworks and

Maybe "any kernel device used to operate the camera" to be more precise
?

> daemons such as Pipewire to better understand the resources consumed by

s/Pipewire/PipeWire/

> a Camera and consider ignoring those resources when enumerating camera
> devices on a system.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> ---
>  src/libcamera/property_ids.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index cb55e0ed2283..6141942969f9 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -690,6 +690,13 @@ controls:
>          that is twice that of the full resolution mode. This value will be valid
>          after the configure method has returned successfully.
>  
> +  - Devices:
> +      type: int64_t
> +      size: [n]
> +      description: |
> +        A list of integer values of type dev_t denoting major and minor device
> +        number of the underlying devices used in the operation of this camera.

s/number/numbers/

I would extend it with

        Different cameras may report identical devices.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +
>    # ----------------------------------------------------------------------------
>    # Draft properties section
>  

-- 
Regards,

Laurent Pinchart