[libcamera-devel] [PATCH] libcamera: meson: Allow PH to change libcamera_deps

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Thu, Jun 08, 2023 at 03:33:25PM +0200, Jacopo Mondi via libcamera-devel wrote:
> From: Naushir Patuck <naush at raspberrypi.com>
> 
> Pipeline handlers can have custom dependencies.
> 
> Allow each pipeline handler subdir to add them to libcamera_deps[].

I wonder how meson will handle the case where multiple pipeline handlers
will add the same dependency. Is this something you've tested ?

> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> ---
>  src/libcamera/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index d438504198fe..3cd424779395 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -58,6 +58,8 @@ includes = [
>      libcamera_includes,
>  ]
> 
> +libcamera_deps = []
> +
>  libatomic = cc.find_library('atomic', required : false)
>  libthreads = dependency('threads')
> 
> @@ -154,7 +156,7 @@ if ipa_sign_module
>      libcamera_sources += ipa_pub_key_cpp
>  endif
> 
> -libcamera_deps = [
> +libcamera_deps += [
>      libatomic,
>      libcamera_base,
>      libcamera_base_private,

-- 
Regards,

Laurent Pinchart