[libcamera-devel] [PATCH 0/2] libcamera: Remove CameraManager::get(dev_t)
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Fri Jun 16 15:42:17 CEST 2023
Hi Kieran,
On Thu, Jun 15, 2023 at 11:51:31PM +0100, Kieran Bingham via libcamera-devel wrote:
> Now that Cameras expose a SystemDevices property which reports any
> associated dev_t identifiers, remove the now redundant implementation of
> CameraManager::get(dev_t) which was provided purely for the V4L2
> Adaptation layer.
>
> The V4L2 adaptation layer reimplements the same functionality relying on
> the SystemDevices data instead.
>
> This series removes a public API function and is a clear break of
> API/ABI.
This function was never meant to be used by applications, so hopefully
nobody will notice :-)
> It is (hopefully clearly) dependant upon the series " libcamera: Add new
> Camera devices property " [0]
>
> [0] https://patchwork.libcamera.org/project/libcamera/list/?series=3925
>
> Kieran Bingham (2):
> v4l2: Use SystemDevices properties to identify cameras
> libcamera: CameraManager: Remove ::get(dev_t)
>
> include/libcamera/camera_manager.h | 1 -
> include/libcamera/internal/camera_manager.h | 3 +-
> src/libcamera/camera_manager.cpp | 42 ---------------------
> src/v4l2/v4l2_compat_manager.cpp | 28 +++++++++++---
> 4 files changed, 24 insertions(+), 50 deletions(-)
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list