[libcamera-devel] [PATCH v4 12/15] py: unittests.py: Fix type checker warnings
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sun Mar 12 16:05:04 CET 2023
Hi Tomi,
Thank you for the patch.
On Thu, Mar 09, 2023 at 04:25:58PM +0200, Tomi Valkeinen via libcamera-devel wrote:
Please add a commit message.
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
> ---
> test/py/unittests.py | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/test/py/unittests.py b/test/py/unittests.py
> index b52b3391..9fd8730e 100755
> --- a/test/py/unittests.py
> +++ b/test/py/unittests.py
> @@ -4,11 +4,9 @@
> # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
>
> from collections import defaultdict
> -import errno
> import gc
> import libcamera as libcam
> import selectors
> -import time
> import typing
> import unittest
> import weakref
> @@ -406,7 +404,7 @@ class SimpleCaptureMethods(CameraTesterBase):
> running = True
> while running:
> events = sel.select()
> - for key, _ in events:
> + for _ in events:
> for ev in cm.get_events():
> self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)
> reqs.append(ev.request)
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list