[libcamera-devel] [PATCH 07/11] pipeline: ipu3: Allow raw-only streams in IPU3 pipeline

Daniel Scally dan.scally at ideasonboard.com
Sun Mar 19 00:40:10 CET 2023


Sensors not connected to the Imgu produce raw-only streams. Allow
that configuration to proceed in the IPU3 pipeline, but warn about
the lack of sensor controls for other sensors.

Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index cc7da299..b9228a59 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -232,18 +232,18 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()
 		return Invalid;
 	} else if (rawCount && !yuvCount) {
 		/*
-		 * Disallow raw-only camera configuration. Currently, ImgU does
-		 * not get configured for raw-only streams and has early return
-		 * in configure(). To support raw-only stream, we do need the IPA
-		 * to get configured since it will setup the sensor controls for
-		 * the capture.
+		 * Currently, ImgU does not get configured for raw-only streams
+		 * and has early return in configure(). To support raw-only stream,
+		 * we do need the IPA to get configured since it will setup the
+		 * sensor controls for the capture. As some sensors _only_ output
+		 * raw streams though we need to allow the configuration to
+		 * continue here.
 		 *
 		 * \todo Configure the ImgU with internal buffers which will enable
 		 * the IPA to get configured for the raw-only camera configuration.
 		 */
 		LOG(IPU3, Debug)
-			<< "Camera configuration cannot support raw-only streams";
-		return Invalid;
+			<< "Sensor controls not supported for raw-only stream";
 	}
 
 	/*
-- 
2.34.1



More information about the libcamera-devel mailing list