[libcamera-devel] [PATCH v1 07/10] ipa: raspberrypi: Make RegionStats::get() always return a Region struct

[David Plowman]

Hi Naush

Thanks for the patch.

On Wed, 22 Mar 2023 at 13:06, Naushir Patuck via libcamera-devel
<libcamera-devel at lists.libcamera.org> wrote:
>
> Update the overloaded RegionStats::get() and RegionStats::getFloating()
> member functions to return a Region struct for consistency.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Thanks!
David

> ---
>  src/ipa/raspberrypi/controller/region_stats.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/controller/region_stats.h b/src/ipa/raspberrypi/controller/region_stats.h
> index 9aaf3a58a6f7..a8860dc8dba2 100644
> --- a/src/ipa/raspberrypi/controller/region_stats.h
> +++ b/src/ipa/raspberrypi/controller/region_stats.h
> @@ -86,12 +86,12 @@ public:
>                 return get_(index);
>         }
>
> -       const T &get(const libcamera::Point &pos) const
> +       const Region &get(const libcamera::Point &pos) const
>         {
>                 return get(pos.y * size_.width + pos.x);
>         }
>
> -       const T &getFloating(unsigned int index) const
> +       const Region &getFloating(unsigned int index) const
>         {
>                 if (index >= numFloatingRegions())
>                         return default_;
> --
> 2.34.1
>