[libcamera-devel] [PATCH v1 07/10] ipa: raspberrypi: Make RegionStats::get() always return a Region struct

[Naushir Patuck]

Hi Jacopo,

Thanks for your review!

On Fri, 24 Mar 2023 at 09:13, Jacopo Mondi <jacopo.mondi at ideasonboard.com>
wrote:

> Hi Naush
>
> On Wed, Mar 22, 2023 at 01:06:09PM +0000, Naushir Patuck via
> libcamera-devel wrote:
> > Update the overloaded RegionStats::get() and RegionStats::getFloating()
> > member functions to return a Region struct for consistency.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > ---
> >  src/ipa/raspberrypi/controller/region_stats.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/ipa/raspberrypi/controller/region_stats.h
> b/src/ipa/raspberrypi/controller/region_stats.h
> > index 9aaf3a58a6f7..a8860dc8dba2 100644
> > --- a/src/ipa/raspberrypi/controller/region_stats.h
> > +++ b/src/ipa/raspberrypi/controller/region_stats.h
> > @@ -86,12 +86,12 @@ public:
> >               return get_(index);
> >       }
> >
> > -     const T &get(const libcamera::Point &pos) const
> > +     const Region &get(const libcamera::Point &pos) const
>
> Was this working because Region has a first member of type T ?
>

This getter was at-this-point unused.  My usage expectation seemed to be
quite
wrong when I originally defined this :-)

Regards,
Naush


>
> Anyway, looks good
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>
> Thanks
>   j
> >       {
> >               return get(pos.y * size_.width + pos.x);
> >       }
> >
> > -     const T &getFloating(unsigned int index) const
> > +     const Region &getFloating(unsigned int index) const
> >       {
> >               if (index >= numFloatingRegions())
> >                       return default_;
> > --
> > 2.34.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20230327/cecbd19a/attachment.htm>