[libcamera-devel] [PATCH v2 2/3] doc: gstreamer: Add missing queues

[Jacopo Mondi]

Hi Nicolas

On Fri, Mar 24, 2023 at 02:12:46PM -0400, Nicolas Dufresne via libcamera-devel wrote:
> From: Nicolas Dufresne <nicolas.dufresne at collabora.com>
>
> As libcamerasrc reports some latency, a queue is needed in order to store the
> data in case the buffers has been produced slightly ahead of our reported
> latency.
>
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

I think we can take this is outside of the larger series in discussion

> ---
>  README.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/README.rst b/README.rst
> index 34b6b49f..52cde91c 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -133,7 +133,7 @@ onto the OpenGL accelerated display element on your system.
>
>  .. code::
>
> -  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! glimagesink
> +  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! queue ! glimagesink
>
>  To show the first camera found you can omit the camera-name property, or you
>  can list the cameras and their capabilities using:
> @@ -164,7 +164,7 @@ the following example could be used as a starting point:
>
>     gst-launch-1.0 libcamerasrc ! \
>          video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \
> -        jpegenc ! multipartmux ! \
> +        queue ! jpegenc ! multipartmux ! \
>          tcpserversink host=0.0.0.0 port=5000
>
>  Which can be received on another device over the network with:
> --
> 2.39.2
>